-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made connection method configurable #8
Conversation
Are you sure this should be configurable? From what i understand VPC instances just did not have public DNS records, we can detect them, and always use private IP instead of public. |
Also linking this issue #7 |
VPC instances can have both private and public DNS records. This should be configurable because, even if I use a VPC, I might be running |
I see, is there is difference then between public_ip and public_dns options? |
👍 Great one, wanted to do the same, cause all my instances are in VPC, and i got only one gateway configured in my .ssh/config |
I'm not quite sure if there is a case where the public dns might not resolve on a certain machine. I generally always use the public/private ip to connect and avoid the dns but we figured it would be useful to allow for either one depending on preference. |
Although I do think you can configure the VPC to not issue DNS entries for machines automatically. I could look into this further if you are trying to avoid having all 4 options (public/private ip and public/private dns). |
any way this could make it in? are there other issues with it? |
Sorry for such long response! Thank you! Merged |
Additionally in config, you can specify how you want it to output, defaults to current output. Added ability to see instance name.