Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made connection method configurable #8

Merged
merged 6 commits into from
May 26, 2016
Merged

Made connection method configurable #8

merged 6 commits into from
May 26, 2016

Conversation

rwillard
Copy link
Contributor

Additionally in config, you can specify how you want it to output, defaults to current output. Added ability to see instance name.

@buger
Copy link
Owner

buger commented Jun 17, 2015

Are you sure this should be configurable? From what i understand VPC instances just did not have public DNS records, we can detect them, and always use private IP instead of public.

@buger
Copy link
Owner

buger commented Jun 17, 2015

Also linking this issue #7

@zeelot
Copy link
Contributor

zeelot commented Jun 17, 2015

VPC instances can have both private and public DNS records. This should be configurable because, even if I use a VPC, I might be running cloud-ssh from a machine that does not have access to the VPC instances over the private network (for example, if I don't have a VPN configured yet).

@buger
Copy link
Owner

buger commented Jun 18, 2015

I see, is there is difference then between public_ip and public_dns options?

@burdandrei
Copy link

👍 Great one, wanted to do the same, cause all my instances are in VPC, and i got only one gateway configured in my .ssh/config

@zeelot
Copy link
Contributor

zeelot commented Jun 25, 2015

I'm not quite sure if there is a case where the public dns might not resolve on a certain machine. I generally always use the public/private ip to connect and avoid the dns but we figured it would be useful to allow for either one depending on preference.

@zeelot
Copy link
Contributor

zeelot commented Jun 25, 2015

Although I do think you can configure the VPC to not issue DNS entries for machines automatically. I could look into this further if you are trying to avoid having all 4 options (public/private ip and public/private dns).

@zeelot
Copy link
Contributor

zeelot commented May 25, 2016

any way this could make it in? are there other issues with it?

@buger
Copy link
Owner

buger commented May 26, 2016

Sorry for such long response! Thank you! Merged

@buger buger merged commit 71299a1 into buger:master May 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants